Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aftershock: Port Augustmoon Start Scenario #72338

Merged
merged 9 commits into from
Mar 20, 2024

Conversation

John-Candlebury
Copy link
Member

Summary

Mods "Aftershock: Create a start scenario within Port Augustmoon"

Purpose of change

This adds what will eventually become the default Aftershock exoplanet gameplay scenario by letting players start within the mod's NPC hub

You spawn within the docking arm of port augustmoon like if you had just taken a shuttle there, after that you are set to trade or inmediatelly leave for the planet (either the exoplanet or the vanilla earth).

Describe the solution

Required adding and rewriting some previous professions so the new scenario wasnt completely empty. The same applied to hobbies/backgrounds so I added a few new ones.

Testing

Spawned a handfull of characters.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Map / Mapgen Overmap, Mapgen, Map extras, Map display Spawn Creatures, items, vehicles, locations appearing on map Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Scenarios New Scenarios, balancing, bugs with scenarios Mods: Aftershock Anything to do with the Aftershock mod Items: Armor / Clothing Armor and clothing EOC: Effects On Condition Anything concerning Effects On Condition labels Mar 12, 2024
@github-actions github-actions bot requested a review from Maleclypse March 12, 2024 13:52
@John-Candlebury John-Candlebury changed the title Port Augustmoon Start Scenario Aftershock: Port Augustmoon Start Scenario Mar 12, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Mar 12, 2024
Copy link
Member

@Maleclypse Maleclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

data/mods/Aftershock/player/hobbies.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 13, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels Mar 19, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A spy and mercenary at the direct service of the Solar Corporations. Touring the frontier in search of intelligence gathering and sabotage contracts. Equipped with a set of irreplacable holographic technology that borders on the miraculous.
  • Proficiencies related to your status within spacefaring culture in all its forms.
  • You have ample experience working in space, either on a station or on a ship. You are familiar with safety protocols, capable of piloting small shuttlecraft and can operate and perform maintenance on a variety of space equipment and colony systems.
  • Your mannerisms and accent are a dead giveaway that you were raised on Earth. Whatever your thoughts about the homeworld might be, the simple fact that you can call it home is likely to affect relationships with people liable to care about such things.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@Fris0uman Fris0uman merged commit 4b935bc into CleverRaven:master Mar 20, 2024
18 of 24 checks passed
@John-Candlebury John-Candlebury deleted the afs-scenarios branch April 14, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Scenarios New Scenarios, balancing, bugs with scenarios Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants