mom: remove no-effect relic_data #72304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there are quiete a few lines in mom going:
"relic_data": { "passive_effects": [ { "has": "HELD", "condition":
"ALWAYS", "values": [ { "value": "MAX_MANA", "add": 0 } ] } ] }
they don't have any effect, I suppose they are for coloring but SS did
not say anything back in the PRs that added those lines, and it is quite
a hacky solution if coloring was the purpose
if coloring was what you were going for you would get more mileage from
using color tags in the item names
github-actions
bot
added
[JSON]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Auto-requesting reviews from non-collaborators: @Standing-Storm
|
Color tags work for item names? TIL. Time to color-code things based on psionic path, then. |
github-actions
bot
added
json-styled
So is this good to merge? |
Standing-Storm
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
there are quite a few lines in mom going:
they don't have any effect, I suppose they are for coloring but SS did not say anything back in the PRs that added those lines, and it is quite a hacky solution if coloring was the purpose
if coloring was what you were going for you would get more mileage from using color tags in the item names
like so:
Describe the solution
Describe alternatives you've considered
Testing
delete lines & check syntax
Additional context