Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mention demo_ui as an example in docs #72303

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

Brambor
Copy link
Contributor

@Brambor Brambor commented Mar 10, 2024

Summary

None

Purpose of change

  • mention demo_ui as an example in docs
  • remove nop operation
  • add empty lines before lists so that lists compile on my local markdown - they already render fine on GitHub

Describe the solution

Describe alternatives you've considered

Testing

Compiled, demo works.
Compiled the docs locally, HTML looks better locally (lists work).

Additional context

Today I wanted to make a ImGui window. According to docs, I looked at input_context.cpp, but didn't manage to get a window running from nothing. So I copied input_context.cpp and input_context.h and cut it down from 2300 lines (.h and .cpp combined) to about 550 lines. But some basic features weren't working. I recently worked with input_context.cpp, so it probably would take even more time for somebody else.

Then, I discovered #72171, got working version pretty fast. The template has only 67 lines, which is amazing. I decided to share this amazingness with whoever reads the docs next. Now my file is like 200 lines and works better!

- remove nop operation
- add empty lines before lists so that lists compile on my local markdown
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 10, 2024
@Maleclypse Maleclypse merged commit 3ccf43b into CleverRaven:master Mar 13, 2024
25 of 28 checks passed
@Brambor Brambor deleted the imgui-help branch March 13, 2024 08:21
SurFlurer added a commit to SurFlurer/Cataclysm-DDA that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants