Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOM] Fix: Intuitive artisan does nothing #72221

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

b3brodie
Copy link
Contributor

@b3brodie b3brodie commented Mar 7, 2024

Summary

Mods "[MOM] Fix: Intuitive artisan does nothing"

Purpose of change

Intuitive artisan actually doesn't apply any of the value granting mutations. While resolving this, I realized that new changes to the code allow defining these values with enchants and math rather than separate mutations.

Describe the solution

Update the intuitive artisan EOC to give the mutations again. Moved the crafting speed bonus from the mutations to an enchant on the effect. I didn't feel that a 1% speed bonus per level after 20 was anything too powerful, and it gives some reason to keep leveling after that (and if anything should be increased because the existing 1% faster crafting per level is just not noticeable).

Describe alternatives you've considered

Laugh internally at Clairsentients thinking they're crafting faster when they're not.

Testing

Cast spell at 1 and at 20 and observed the crafting speed difference. Also saw that the mutations were added.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter labels Mar 7, 2024
@Standing-Storm
Copy link
Contributor

Standing-Storm commented Mar 7, 2024

It looks like...the application of the mutations somehow got deleted in #71999?? How did I manage to do that?

+6 bonus and much quicker crafting.

This is much too strong a bonus when compared to the original power. The mutation-based skill bonuses are set up so that // Skill affected by the mutation and their bonuses. Bonuses can be negative, a bonus of 4 is worth 1 full skill level., so the maximum bonus from the mutation-based version was 1.5 levels. That's why I haven't fully changed it over to enchants yet, because the "skills" property of enchants is integer only and can't handle the granularity that mutations can yet.

The speed though will benefit from being an enchant because then it can be affected by Nether Attunement.

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Mar 7, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Mar 7, 2024
@b3brodie
Copy link
Contributor Author

b3brodie commented Mar 7, 2024

Ah, I didn't realize that the mutation values were 0.25 of a skill level. I added back the mutations for the skill boosts and fixed the EOC to give them.

@b3brodie b3brodie marked this pull request as ready for review March 7, 2024 06:47
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @Standing-Storm

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 7, 2024
@dseguin dseguin merged commit 1fde0aa into CleverRaven:master Mar 8, 2024
29 of 38 checks passed
@b3brodie b3brodie deleted the mom_artisan2 branch March 8, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants