Revert "[BombasticPerks] A new playstyle perk: Enchanting Master" #72217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Documentation>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Auto-requesting reviews from non-collaborators: @bombasticSlacks
github-actions
bot
added
the
astyled
This comment was marked as off-topic.
This comment was marked as off-topic.
SPD being shattered pixel dungeon
kevingranade
force-pushed
the
revert-71702-CUSTOM_ITEM_SUFFIX
branch
from
790c7bb to
2a9b20d
Compare
|
I wonder if there are other texts with copyright issues like this. After all these are hard to spot and thus may have slipped in more than once. This also reminds me of seeing a description which looked like it was directly copied from Wikipedia (which is using CC-BY-SA 4.0 so we can probably just attribute to it?) |
github-actions
bot
added
the
json-styled
|
It is something we need to watch out for yes. |
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Reverts #71702
This was directly copying from shattered pixel dungeon without attribution.
The names aren't necessarily a problem, but the descriptions must be original.