Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the standard building palette #72164

Merged

Conversation

Milopetilo
Copy link
Contributor

Summary

Infrastructure "Update the standard building palette"

Purpose of change

I was planning on putting the library from urban development into the game with some updates, and upon looking at what palettes the library already in the game used, I discovered that the standard_building palette didn't have parametrized walls and vandalized variants had to be manually added.

Describe the solution

Make the palette use params for walls and give the palette a chance to be a vandalized version. I've mostly gotten the logic from domestic_general_and_variant_palette.

Describe alternatives you've considered

Not do this
Make it have more levels of vandalism/destruction

Testing

Game loads, omts that used the palette properly use the new palette

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Mar 4, 2024
data/json/mapgen/library.json Outdated Show resolved Hide resolved
data/json/mapgen/library.json Outdated Show resolved Hide resolved
data/json/mapgen/library.json Outdated Show resolved Hide resolved
data/json/mapgen/library.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Mar 4, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 4, 2024
@Maleclypse Maleclypse merged commit 03d25c2 into CleverRaven:master Mar 4, 2024
18 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants