[Magiclysm] Direct butchering kit enchanting #72087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgot to fix proportional warmth
The patches were the same mass as the breeches you created with 20 of them, so I divided the patch mass by 20 to make logical sense. This means that the gambeson pieces I'm making are going to take far more of the patches, but that seems fitting
The patch to garment mass ratio was all off for the pants, so I adjusted the patch's mass and have now adjusted the gambeson's patch quantities based on that mass
Adjusted per conversation on discord. .6 times the mass of cotton, or otherwise compared to wool appropriately
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
[JSON]
|
Oh I must have messed up real bad when making my last PR. I'll fix that master branch when this PR is done, everything but the last commit isn't real for this PR. |
github-actions
bot
added
json-styled
|
Those test failures don't seem related to this PR, but it's not impossible I could be wrong about that? |
github-actions
bot
removed
the
BasicBuildPassed
|
Okay, I'm definitely confused as to what exactly failed that test there. It didn't fail before. |
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
You could assemble butchering kits out of +1 and +2 knives, but you couldn't directly enchant them. This changes that.
Describe the solution
Add a recipe to enchant butchering kits directly, taking three times as long as other enchanting recipes because you're enchanting three knives in a single recipe.
Describe alternatives you've considered
Continuing to disassemble my butchering kits whenever it's time to upgrade? Adding batch time savings? I did not do the latter because none of the other enchanting recipes have batch savings, so this one shouldn't either.
Testing
Checked to make sure recipes came from book as they should, recipes took the right amount of time, recipes taught proficiency correctly, recipes produced items correctly. Old recipes for butchering kits still worked. I can't think of any other way to test this?
Additional context
This is a very tiny QoL change that is absolutely not necessary, to the point where I absolutely spent more time making this PR than I would ever have spent actually disassembling and reassembling butchering kits over my entire lifetime, but I figured it'd be a nice little bit of convenience for others too.