Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Update Cloak of Elvenkind to use new enchantments #72081

Merged

Conversation

Standing-Storm
Copy link
Contributor

Summary

Mods "[Magiclysm] Update Cloak of Elvenkind to use new enchantments"

Purpose of change

Previously the cloak of elvenkind needed a dummy effect and two EoCs to work properly. Now, it just needs a conditional STEALTH_MODIFIER enchant.

Describe the solution

Add a conditional STEALTH_MODIFIER enchantment.

Describe alternatives you've considered

Testing

The conditional STEALTH_MODIFIER enchantment works.

Additional context

Old EoCs and mutation have been preserved in an obsoletion directory so any old cloaks still work.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Mods: Magiclysm Anything to do with the Magiclysm mod EOC: Effects On Condition Anything concerning Effects On Condition labels Feb 29, 2024
@github-actions github-actions bot requested a review from KorGgenT February 29, 2024 22:08
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Feb 29, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 3, 2024
@Maleclypse Maleclypse merged commit 4b61ec3 into CleverRaven:master Mar 4, 2024
19 of 24 checks passed
@Standing-Storm Standing-Storm deleted the cloak-of-elvenkind-fix branch March 4, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants