Fixing an imgui-related crash related to debug errors #72074
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "When a debug error is thrown during drawing, imgui itself throws an exception, crashing the game"
Purpose of change
When draw errors happen, we expect to see the debug message. Instead, CDDA crashes. This prevents this
Fixes: #72047
Describe the solution
Added a boolean in ui_manager.cpp to prevent cataimgui::client::new_frame to be called twice in a row
Describe alternatives you've considered
Could have added the boolean inside cataimgui::client::new_frame but currently there are multiple definitions, for curses and SDL. This bypasses needing to make the same change in 2 places
Testing
Loaded the save specified in the linked issue and verified the debug error is shown
Additional context