Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "fix some bugs for
run_eoc_until
"Purpose of change
In the documentation, one field is "iteration", but in the code, the checked field is "iteration_count"
When the iteration number is too large, a debugmsg occurs within
eoc->activate
due to the callstack of dialogue being too large.The condition of
run_eoc_until
can only be set in advance usingset_condition
. I don't understand the significance of this. Can't we just use the condition syntax directly?Describe the solution
I changed the "iteration_count" in the code to "iteration".
Add a bool value
require_callstack_check
ineoc->activate
to determine whether to amend the eoc in the callstack and check the size of callstack. Then, inrun_eoc_until
, amend one eoc into the callstack instead of amending several eocs into the callstack repeatedly in the iteration.use condition syntax directly.
Describe alternatives you've considered
Testing
Test function is updated.
Additional context