Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xedra Evolved] Paraclesian altar wall rework #72008

Merged

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Feb 26, 2024

Summary

Mods "[Xedra Evolved] Paraclesian altar wall rework"

Purpose of change

I thought it was a little weird that every altar had hedges instead of something elementally appropriate.

Describe the solution

Change the hedges to something more appropriate:

Arvore: Trees.
Ierde: A mix of solid rock or dirt.
Homullus: A mix of scrap metal or brick walls
Salamander: Obsidian and, rarely, lava, borrowing the terrain from #69553
Sylph: Walls of solid fog (impassible field)
Undine: Walls of water (using the t_water_cube terrain)

Describe alternatives you've considered

Testing

Arvore:
image

Ierde:
image

Homullus:
image

Salamander:
image

Sylph:
image

Undine:
image

Additional context

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [Markdown] Markdown issues and PRs Mods: Xedra Evolved Anything to do with Xedra Evolved labels Feb 26, 2024
@github-actions github-actions bot requested a review from Maleclypse February 26, 2024 22:21
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 26, 2024
@Maleclypse Maleclypse merged commit 1b34405 into CleverRaven:master Feb 27, 2024
25 checks passed
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 27, 2024
@Standing-Storm Standing-Storm deleted the paraclesian-altar-wall-rework branch February 27, 2024 04:40
@Rokharn
Copy link

Rokharn commented Feb 27, 2024

Will the newborn salamander be able to get out of his dungeon, despite the danger of the lava fields? Heat from lava very dangerous.

@Standing-Storm
Copy link
Contributor Author

Standing-Storm commented Feb 27, 2024

Will the newborn salamander be able to get out of his dungeon, despite the danger of the lava fields? Heat from lava very dangerous.

Yes--there's multiple ways out and just running past lava isn't hot enough to be dangerous (maybe it should be, but it currently is not). As you can see, the lava tiles occur rarely and never actually block the path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Documentation> Design documents, internal info, guides and help. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display [Markdown] Markdown issues and PRs Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants