More enchantments #71976
Merged
More enchantments #71976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Documentation>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Auto-requesting reviews from non-collaborators: @Standing-Storm
github-actions
bot
added
the
astyled
GuardianDll
force-pushed
the
enchantment_2
branch
from
075e731 to
c82b8b1
Compare
github-actions
bot
added
the
json-styled
GuardianDll
force-pushed
the
enchantment_2
branch
from
c82b8b1 to
61caba3
Compare
github-actions
bot
added
the
Code: Tests
At last, witch's curses can come to Xedra Evolved. Edit: does NIGHT_VIS add squares, or multiply existing vision range? Like, if you have |
|
Night_vis is a flat value, so adding adds amount of tiles to vision range |
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Followup to #71926
Describe the solution
Even more enchantments:
-MOVECOST_SWIM_MOD
-MOVECOST_OBSTACLE_MOD
-MOVECOST_FLATGROUND_MOD
-SHOUT_NOISE_BASE
-SHOUT_NOISE_STR_MULT
-NIGHT_VIS
-HEARING_MULT
-BANDAGE_BONUS
-DISINFECTANT_BONUS
-BLEED_STOP_BONUS
-UGLINESS
-VOMIT_MUL
Cleanup the code and replace hardcoded interactions with enchantments where possible
Replace
SUPER_HEARINGflag withSAFECRACK_NO_TOOLflag since now it doesn't give any hearing bonus on it's ownTesting
Additional context
I want add more, thoughts?
Also, i know we would like to move to enchantments, should i replace the mutation/bionic effects with enchantments? like replacing
hearing_modifierwithHEARING_MULT, or even remove hearing_modifier from the code?