keybindings buttons: one per line & fixes #71954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: KBs was invisible (and more shenanigans) when "Press ."... is shown - my bad CleverRaven#71060 fix: highlight at proper line (not line above) - my bad CleverRaven#71060 fix: on small window, highlight and clickable region is off x-coordinate change: each button is on it's own line, so I made it you can click anywhere on the line to activate the button
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
[C++]
SurFlurer
added a commit
to SurFlurer/Cataclysm-DDA
that referenced
this pull request
Mar 19, 2024
This reverts commit d1d224d.
SurFlurer
added a commit
to SurFlurer/Cataclysm-DDA
that referenced
this pull request
Mar 19, 2024
This reverts commit d1d224d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
fix: KBs was invisible (and more shenanigans) when "Press ."... is shown - my bad #71060
fix: highlight at proper line (not line above) - my bad #71060
fix: on small window, highlight and clickable region is off x-coordinate
Describe the solution
Each button is on it's own line. I made it you can click anywhere on the line to activate the button.
Before
After
Describe alternatives you've considered
Just fix the issues I made and the scaling issue. This code is better for user and more maintainable.
Another button needs adding and it started to be quite a mess already.
Testing
Clicked the buttons. They do the same things.
?keybinding)Additional context
Layout inspired by buttons in #65709.
Unfortunatelly, this is not rebase friendly with #65709.