Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unviable portal life forms #71934

Merged
merged 20 commits into from
Apr 29, 2024
Merged

Conversation

NetSysFire
Copy link
Member

@NetSysFire NetSysFire commented Feb 23, 2024

Summary

Content "New portal monsters: unviable life forms"

Purpose of change

I actually did not mean to file it already, but this is the easiest way for reviewers.

Not only mi-gos and shoggoths emerge from the portals. Also a lot of things that are simply not at home here and this represents that. Portal fodder, mildly dangerous with some exceptions, as in they can still (try to) bite off your finger if you go poke them.
Also great for flavor.

Describe the solution

Mostly a placeholder right now. Tests will fail.

Describe alternatives you've considered

Testing

Spawned them. Made them attack me. Looked at natural portal spawns. Butchered them.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map labels Feb 23, 2024
@Spicyshadow
Copy link

What do these creatures give when butchered? It wouldn´t make sense for them to give tainted or mutant meat.

@NetSysFire
Copy link
Member Author

They are your "ordinary" eldritch creatures in that aspect, similar to mi-gos, which do give you tainted meat iirc.
I think the butterfly can just die without leaving a corpse though. I'll find some tainted bug and plant meat for the strange bug and writhing root. The other two are meaty.

@github-actions github-actions bot added Mechanics: Enchantments / Spells Enchantments and spells json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels Mar 11, 2024
@NetSysFire NetSysFire marked this pull request as ready for review April 12, 2024 10:40
@NetSysFire
Copy link
Member Author

This should be good to go now. I am totally out of energy to continue anyways.

Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • eldritch stomper

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

Copy link
Member

@Venera3 Venera3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the flavor on them. Some monstery nitpicks but nothing major.

data/json/monsters/nether.json Show resolved Hide resolved
data/json/monsters/nether.json Show resolved Hide resolved
@I-am-Erk
Copy link
Member

note that technically mi-go aren't supposed to be portal creatures. They can use portals but they're not extradimensional in origin

@NetSysFire
Copy link
Member Author

note that technically mi-go aren't supposed to be portal creatures. They can use portals but they're not extradimensional in origin

How is that relevant here? I have not touched mi-gos, only a mongroup in which they appear.

Before you start to brainstorm about potential replacements for mi-go, please make that a dedicated issue because it will be lost and forgotten in here.

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 14, 2024
@I-am-Erk
Copy link
Member

I'm just mentioning it because you mentioned them, no other reason

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 26, 2024
"aggression": 20,
"bodytype": "blob",
"harvest": "mutant_tiny",
"zombify_into": "mon_meat_cocoon_tiny",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"zombify_into": "mon_meat_cocoon_tiny",
"zombify_into": "mon_meat_cocoon_tiny",

I'm going ahead and merging this but I could go either way on whether these nether creatures zombify into anything or not.

@Maleclypse Maleclypse merged commit 5d07beb into CleverRaven:master Apr 29, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants