Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bombastic Perks] Add overwriting perkchain support #71898

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Feb 21, 2024

Summary

Mods "[Bombastic Perks] Add overwriting perkchain support"

Purpose of change

I wanted to add additional +1 stat perks to Bombastic Perks but not clutter up the mutation menu, but since the basic engine used u_add_trait there was no way to do that. However, swapping it over to u_mutate_towards should keep all basic behavior the same while allowing perks later in chains to overwrite perks earlier in chains, so that (for example) Stronger becomes Even Stronger and +1 STR becomes +2, rather than simply having Even Stronger give you another +1 and having both in your menu simultaneously.

Describe the solution

Change u_add_trait to u_mutate_towards. Add additional +1 stat perks that overwrite the previous perks in their chain, allowing +2 to all stats (at the cost of 8 perk points).

Describe alternatives you've considered

Testing

Previous perks are properly selectable, new perks in the chain are not selectable unless previous perks are taken, previous perks in the chain cannot be selected a second time after taking the later perks, and part 2 of the chain properly overwrites part 1:
image

Additional context

This should also allow adding otherwise-unselectable starting traits as perks, since u_mutate_towards respects the cancels field.

@Standing-Storm Standing-Storm marked this pull request as draft February 21, 2024 18:02
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Bombastic Perks labels Feb 21, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • You HAVE been doing cardio. +2 Dexterity.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 21, 2024
@ashGlaw
Copy link
Contributor

ashGlaw commented Feb 21, 2024

Good idea, and better infrastructure for future changes

@Standing-Storm Standing-Storm marked this pull request as ready for review February 22, 2024 02:09
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @bombasticSlacks

@Maleclypse Maleclypse merged commit b8a364a into CleverRaven:master Feb 23, 2024
25 checks passed
@Standing-Storm Standing-Storm deleted the perkchain-support branch February 23, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Bombastic Perks Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants