Fix infinite looping in msvc builds in fragment test function #71811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My debug code in #71585 introduced a divide by zero, resulting in infinite fragmentation density. It seems the msvc std::poisson_distribution constructor doesn't like infinite values.
github-actions
bot
added
Code: Tests
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
My debug code in #71585 introduced a divide by zero, resulting in infinite fragmentation density.
It seems the msvc std::poisson_distribution constructor doesn't like infinite values.
Describe the solution
Floor the range passed to shrapnel_calc() by the debug code at 1 so it can't divide by zero.
Describe alternatives you've considered
Remove the debug code I guess?
Testing
I can't reproduce locally, so see if this fixes the infinite loop in the MSVC build.
Additional context
REALLY MSVC? REALLY?