Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in clang-tidy.sh #71797

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Fix error in clang-tidy.sh #71797

merged 1 commit into from
Feb 17, 2024

Conversation

BrettDong
Copy link
Member

Summary

None

Purpose of change

Reference to the variable $tidyable_cpp_files misses a dollar sign in clang-tidy.sh:

    if [ "tidyable_cpp_files" == "unknown" ]

This causes clang-tidy CI failure https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/7924118545/job/21635122976#step:9:1646

Describe the solution

Add the missing $.

Describe alternatives you've considered

Testing

Additional context

@BrettDong BrettDong requested a review from akrieger February 17, 2024 02:20
@github-actions github-actions bot added Code: Build Issues regarding different builds and build environments astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 17, 2024
@akrieger akrieger merged commit 703087c into master Feb 17, 2024
24 of 25 checks passed
@akrieger akrieger deleted the clang-tidy-sh branch February 17, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Build Issues regarding different builds and build environments json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants