Remove the Valhallists for 0.I experimental #71705
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Remove final mentions of Valhallists."
Purpose of change
The Valhallists were added and then obsoleted in 0.G, and their files have remained dormant for a long time. They needed a lot of work to fit into the base game with the state they are in, as it teetered just over the edge of what was reasonably realistic, despite two attempts to rework them. It's a project I no longer have the time for, and thus be able to do, as I've gathered other project commitments with different NPC factions.
Describe the solution
Remove the remaining files for the Valhallist NPCs, including missions, snippets, and the vehicle purchasing system. Also delete the faction ID and epilogue snippets from their relevant files. Everything else has already been obsoleted, and #71666 removes that as part of it's content
Describe alternatives you've considered
Reviving and fixing the Valhallists, which would require lots of design and discussion with head developers to create a lore-friendly faction, which would probably look significantly different from what is already present. This is also a lot of work that I don't have the time for at the moment.
Testing
N/A, none of this has been reflecting in game since 2023.
Additional context
@Maleclypse I've got the files in reserve for your use, since I recall you'd mentioned wanting to do something with them for Xedra Evolved.