Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Valhallists for 0.I experimental #71705

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

MNG-cataclysm
Copy link
Contributor

Summary

Content "Remove final mentions of Valhallists."

Purpose of change

The Valhallists were added and then obsoleted in 0.G, and their files have remained dormant for a long time. They needed a lot of work to fit into the base game with the state they are in, as it teetered just over the edge of what was reasonably realistic, despite two attempts to rework them. It's a project I no longer have the time for, and thus be able to do, as I've gathered other project commitments with different NPC factions.

Describe the solution

Remove the remaining files for the Valhallist NPCs, including missions, snippets, and the vehicle purchasing system. Also delete the faction ID and epilogue snippets from their relevant files. Everything else has already been obsoleted, and #71666 removes that as part of it's content

Describe alternatives you've considered

Reviving and fixing the Valhallists, which would require lots of design and discussion with head developers to create a lore-friendly faction, which would probably look significantly different from what is already present. This is also a lot of work that I don't have the time for at the moment.

Testing

N/A, none of this has been reflecting in game since 2023.

Additional context

@Maleclypse I've got the files in reserve for your use, since I recall you'd mentioned wanting to do something with them for Xedra Evolved.

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON Missions Quests and missions Lore Game lore, in-game communication. Also the Lore tab. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 12, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 12, 2024
@Maleclypse Maleclypse merged commit d2b96b2 into CleverRaven:master Feb 22, 2024
24 checks passed
@MNG-cataclysm MNG-cataclysm deleted the valhallist_final_remove branch February 23, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Lore Game lore, in-game communication. Also the Lore tab. Missions Quests and missions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants