show danger radius in overmap note list #71628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Info / User Interface
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
json-styled
github-actions
bot
added
the
astyled
nornagon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface "Show danger radius in note list"
Purpose of change
Ref #71577. This adds some indication in the note list UI that a particular
note has a danger radius associated with it.
Describe the solution
Added a new
note_danger_radiusmethod, because this information wasn'tpreviously exposed by the overmap interface.
Also makes the "DANGEROUS AREA" text translated, and changes it to "IN DANGEROUS AREA" for notes that are not themselves marked dangerous (but which fall inside a danger zone).
Describe alternatives you've considered
Perhaps the whole
om_notestruct ought to be exposed..?Testing
Tested locally.
Additional context
NB there is a bug in trim_by_length which messes up the color when the note name is very long. I'll attempt to address this separately: