fix wrong scaling on hidpi screens in emscripten #71436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
nornagon
pushed a commit
to nornagon/Cataclysm-DDA
that referenced
this pull request
Jun 7, 2024
fix wrong scaling on hidpi screens in emscripten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Without this, the game only takes up the top-left 1/4 of the screen on high-dpi screens.
Describe the solution
Removing the "ALLOW_HIGHDPI" flag would be bad on non-Web builds because it would give you a blurry window (I think?). But on the web, we force the rendering to be simple 2x scale without blurring using
image-rendering: pixelated, so this isn't a problem—we just pretend we don't have a highdpi window :)Describe alternatives you've considered
Testing
Tested by downloading the CI artifact, serving it locally with
npx serveand loading the game on a high-dpi screen.Additional context