Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract widget string for translation #71420

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

Uwuewsky
Copy link
Contributor

@Uwuewsky Uwuewsky commented Feb 2, 2024

Summary

I18N "Extract widget string for translation"

Purpose of change

Some widgets were not extracted for translation. This change retrieves about 66 strings.

Describe the solution

The UI files don't seem to use "strings" arrays fields, grep doesn't show anything, they use single "string" fields.

Describe alternatives you've considered

Testing

Everything looks fine.

Screenshots

Before:
before

After:
after

Additional context

btw some widget names are the same, although they differ in meaning.

#. ~ Default clause of UI widget "compass_S_danger_label"
#. ~ Clause text "safe_mode_trigger" of UI widget "compass_S_danger_label"
#. ~ Clause text "danger" of UI widget "compass_S_danger_label"
#. ~ Text in UI widget "l_str"
#. ~ Text in UI widget "l_stamina"
#: data/json/ui/compass_danger.json data/json/ui/sidebar-mobile.json
msgid "S:"
msgstr ""

One line is used to name the cardinal direction, stamina and strength.

Maybe it's worth adding a context flag to json.

oh, the documentation says about context, maybe I'll take that later

@github-actions github-actions bot added Translation I18n Info / User Interface Game - player communication, menus, etc. [Python] Code made in Python labels Feb 2, 2024
Copy link
Contributor

github-actions bot commented Feb 2, 2024

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • => ( HP/Status/Encum./Temp./swet ) <=

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 2, 2024
@dseguin dseguin merged commit d1b9dda into CleverRaven:master Feb 2, 2024
19 of 23 checks passed
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 2, 2024
@Uwuewsky Uwuewsky deleted the extract-ui branch February 3, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions [Python] Code made in Python Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants