Fix the inconsistency between the aiming prediction time and the actual time #71406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
When players use the "to steady your aim" method to approach the accuracy limit, they will find that the aiming time prediction of precision shooting mode is different from the actual time spent. The purpose of this PR is to fix this problem.
Describe the solution
The function "Character::gun_engagement_moves" called in the original code is used to roughly estimate the gun's aiming performance in the item interface. It is different from the algorithm used in the actual aiming process. So I use the function “predict_recoil” to replace it.
Describe alternatives you've considered
Testing
Tested in game and find the bug has been fixed.
Additional context