Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send item id as variable to use_action EoC #71392

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

Andrei gave me a code, that'd allow me to simplify json a bit, as it will pass the item id as context variable id to the EoC that this item uses

Describe the solution

Add said code, simplify a bit of EoCs that passed said id manually every time, document the fact there is a context variable id

Testing

Contact lenses are applied as expected, saline solution is used as expected

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs EOC: Effects On Condition Anything concerning Effects On Condition astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jan 31, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 1, 2024
@Maleclypse Maleclypse merged commit ab5aa03 into CleverRaven:master Feb 1, 2024
24 of 26 checks passed
@GuardianDll GuardianDll deleted the item_id_to_eoc branch February 1, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants