-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Magiclysm] Reduce Hoarder penalty for Ravenfolk #71365
Merged
Maleclypse
merged 10 commits into
CleverRaven:master
from
Standing-Storm:ravenfolk-hoarder
Feb 1, 2024
Merged
[Magiclysm] Reduce Hoarder penalty for Ravenfolk #71365
Maleclypse
merged 10 commits into
CleverRaven:master
from
Standing-Storm:ravenfolk-hoarder
Feb 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
Changes (can be) made in C++. Previously named `Code`
Mods
Issues related to mods or modding
json-styled
JSON lint passed, label assigned by github actions
labels
Jan 30, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
astyled
astyled PR, label is assigned by github actions
label
Jan 30, 2024
github-actions
bot
removed
the
astyled
astyled PR, label is assigned by github actions
label
Jan 30, 2024
github-actions
bot
added
the
astyled
astyled PR, label is assigned by github actions
label
Jan 30, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[C++]
Changes (can be) made in C++. Previously named `Code`
json-styled
JSON lint passed, label assigned by github actions
Mods
Issues related to mods or modding
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[Magiclysm] Reduce Hoarder penalty for Ravenfolk"
Purpose of change
I gave Ravenfolk Hoarder because of the idea of ravens making caches of shiny objects, and Hoarder is the closest even though it's not specific about what kind of objects you're hoarding. But with how big the morale penalty gets, Hoarder the trait clearly represents an extreme version of hoarding and not just wanting to hang on to trinkets. A new trait would be best, but until I figure how to make one, the morale penalty should be reduced.
Describe the solution
Ravenfolk keep Hoarder, but the morale penalty is quartered for them.
Describe alternatives you've considered
Testing
Evac shelter start, no change: -70 morale
Evac shelter start, change: -17 morale, 1/4th (accounting for dropped fractions)
Additional context