Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Reduce Hoarder penalty for Ravenfolk #71365

Merged
merged 10 commits into from
Feb 1, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Jan 30, 2024

Summary

Mods "[Magiclysm] Reduce Hoarder penalty for Ravenfolk"

Purpose of change

I gave Ravenfolk Hoarder because of the idea of ravens making caches of shiny objects, and Hoarder is the closest even though it's not specific about what kind of objects you're hoarding. But with how big the morale penalty gets, Hoarder the trait clearly represents an extreme version of hoarding and not just wanting to hang on to trinkets. A new trait would be best, but until I figure how to make one, the morale penalty should be reduced.

Describe the solution

Ravenfolk keep Hoarder, but the morale penalty is quartered for them.

Describe alternatives you've considered

Testing

Evac shelter start, no change: -70 morale

Evac shelter start, change: -17 morale, 1/4th (accounting for dropped fractions)

Additional context

@Standing-Storm Standing-Storm marked this pull request as draft January 30, 2024 20:26
@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Mods Issues related to mods or modding json-styled JSON lint passed, label assigned by github actions labels Jan 30, 2024
src/character_morale.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Jan 30, 2024
@github-actions github-actions bot removed the astyled astyled PR, label is assigned by github actions label Jan 30, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Jan 30, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review January 31, 2024 03:53
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 31, 2024
@Maleclypse Maleclypse merged commit 7ecb3c1 into CleverRaven:master Feb 1, 2024
21 of 26 checks passed
@Standing-Storm Standing-Storm deleted the ravenfolk-hoarder branch February 1, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants