Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Increase goblin night vision #71357

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Jan 30, 2024

Summary

Mods "[Magiclysm] Increase goblin night vision"

Purpose of change

The intent when I made goblins nocturnal was to provide an interesting playstyle choice--now you have to do nighttime raids because you're nearly blind during the day (and since there are feral goblins and dwarves out there, nighttime raids are more dangerous than in vanilla). But, their actual night vision didn't really make up the difference. Obviously, no night vision is going to let you see as far at night as during the day (barring magic), but it should still be a bit better.

Describe the solution

Swap out Full Nightvision for a custom mutation that provides a night_vis limb score.

Describe alternatives you've considered

Testing

Night Vision:
image

vs. day vision:
image

Additional context

Once limbs are in a more workable state, they can just have Goblin Eyes as a limb replacement that do the same thing.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod labels Jan 30, 2024
@github-actions github-actions bot requested a review from KorGgenT January 30, 2024 04:46
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @GuardianDll

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 30, 2024
@Maleclypse Maleclypse merged commit bebc4a5 into CleverRaven:master Jan 31, 2024
24 checks passed
@Standing-Storm Standing-Storm deleted the goblin-eyes branch January 31, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants