Change how CMake generates version files #71316
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Build "Change how CMake generates version files"
Purpose of change
I've found the
version.cmake
was a duplicate of what done at configuration time.Describe the solution
✅ Moved
version.h
andVERSION.txt
generation intoversion.cmake
.✅ Only revwrite
version.h
if the version found by git is different. This is howMakefile
does it✅ In
src/
, useCMAKE_CURRENT_SOURCE_DIR
instead ofCMAKE_SOURCE_DIR/src
because why notDescribe alternatives you've considered
❌ Oddly thought that making
getVersionString()
constexpr
would have been different then a preprocessor macro 🤦♂️ ...Testing
✅ Visual Studio CMake preset build
✅ MSVC Command line CMake preset build
✅ Ubuntu WSL2 command line CMake preset build
Additional context
None