Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix seen cache not updating on lower z-levels #71308

Closed
wants to merge 1 commit into from
Closed

Fix seen cache not updating on lower z-levels #71308

wants to merge 1 commit into from

Conversation

Rewryte
Copy link
Contributor

@Rewryte Rewryte commented Jan 28, 2024

Summary

Bugfixes "Fix seen cache not updating on lower z-levels"

Purpose of change

Seen cache does not update properly on z-levels below the player when experimental 3D setting is off.
Fixes #71185

Describe the solution

Fix a check in map::build_seen_cache

Describe alternatives you've considered

Testing

Builds successfully.
Confirmed issue fixed.

Additional context

@Qrox
Copy link
Contributor

Qrox commented Jan 28, 2024

#71306 already removes the single z-level mode.

@Rewryte
Copy link
Contributor Author

Rewryte commented Jan 28, 2024

#71306 already removes the single z-level mode.

Yeah, only saw your PR after I posted this. Will close this when #71306 is merged. Nice work!

@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 28, 2024
@Rewryte
Copy link
Contributor Author

Rewryte commented Jan 31, 2024

Closed in favor of #71306.

@Rewryte Rewryte closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terrain tiles on different z level no longer drawing.
2 participants
@Rewryte @Qrox