eoc/math: port all shimmed functions to native math #71216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Documentation>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Auto-requesting reviews from non-collaborators: @GuardianDll @Standing-Storm
andrei8l
force-pushed
the
math-no-shim
branch
from
fa1e663 to
659d721
Compare
andrei8l
force-pushed
the
math-no-shim
branch
from
659d721 to
3d25d18
Compare
|
compiled, loaded up a saved game, wandered the earth, no issues. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Prepare to delete the math parser shim. It has served its purpose and it's nearly time for it to go.
Describe the solution
Port all
u_val()functions with fake kwargs to native math.Delete the corresponding code from old functions.
Delete some other dead code in the same functions that corresponds to unimplemented wishes and dreams that I don't want to carry around.
Describe alternatives you've considered
N/A
Testing
Test units?
Additional context
I can't delete the shim yet because the code requires a bit more untangling