Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added transition contacts #71187

Merged
merged 2 commits into from
Jan 27, 2024

Conversation

DragonWizard23
Copy link
Contributor

@DragonWizard23 DragonWizard23 commented Jan 23, 2024

Summary

Content "Added transition contacts"

Purpose of change

I recently learned about contact lenses that darken in bright light and thought they sounded cool, so I've introduced them as a rare spawn in the same locations where regular contacts can spawn, but at about 1/10 the frequency.

Describe the solution

I added transition contact lenses based off of the standard contacts from PR #4573. They are virtually identical, except for the description and the SUN_GLASSES flag. However, the SUN_GLASSES flag is not yet working with the transition contacts. @GuardianDll is working on EoC-ifying the old contacts code and encouraged me to push this incomplete implementation in the meantime.

Describe alternatives you've considered

I thought it would be cool if the lenses had a delay for the transition period, but that is beyond me. For consistency, that should also affect transition eyeglasses.

Testing

I debug spawned the lenses and put them on, and they gave the contact lenses effect. However, the transition contacts currently do not prevent "Glare (eyes)" when outside in bright sunlight.
Due to the low spawn rate, I haven't been able to confirm that they spawn naturally, but I'm pretty confident it is working as intended.

Additional context

For reference, here's a comparison of the lenses at different levels of darkness, and a link to a website that explains more about them.
cdn cliqueinc com__cache__posts__263446__acuvue-transition-contact-lenses-263446-1532032700019-fb 700x0c-5ed370d0f51e4d0e9ac6b44ebc5ff626

Defined transition_contacts, and added spawns for them where contacts are found, but at 1/10 the rate, except for the mansion and tech spawns.
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map astyled astyled PR, label is assigned by github actions labels Jan 23, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A pair of extended-wear contacts with soft lenses designed to be discarded after a week of use. This high tech pair darkens in response to light, making it easier to see in bright environments. They sit comfortably on the surface of the eye.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@DragonWizard23 DragonWizard23 marked this pull request as ready for review January 25, 2024 23:26
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 25, 2024
@Maleclypse Maleclypse merged commit ab85289 into CleverRaven:master Jan 27, 2024
27 of 32 checks passed
@Montimorency
Copy link
Contributor

This is of minimal relevance to most, but could you increase the price of the transition contacts to be above that of regular contacts? Transition glasses range from $7.50 to $75.00 in barter value, whereas standard glasses start at $5. That ($5) might be a good benchmark at which to set transition contacts between plain contacts and the range of glasses in value.

Also, should the prices in the json have the string "cent" in them? All other items seem to have a purely numerical price value.

@DragonWizard23
Copy link
Contributor Author

@Montimorency Thanks for the input! I think the "cent" is benign old code, but the barter value (and pre-apoc) value were an oversight. I will see about updating those prices and maybe reviewing the prices for eyewear in general to be more self-consistent. :)

@GuardianDll
Copy link
Member

very lucky for you, #71323 changed the price of transition contact to 6$

@DragonWizard23 DragonWizard23 deleted the Transition-Contacts branch April 23, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants