DEBUG_ONLY flag for more consistency in "seeing this is a bug" #71065
+81
−108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
We have a dozen or more ways of saying "seeing this is a bug" and I find that we duplicate this pointlessly, so this is an effort to have some consistency.
Describe the solution
DEBUG_ONLY
flagfake_item
and createsfake_crafting_item
for deduplicating use.fake_item
now also hasTRADER_AVOID
Includes: Bonus typo and terminal punctuation (consistency!) fixes in
flags.json
Describe alternatives you've considered
Testing
Loads and looks fine. Though I have not tested the recipes yet and I hope the tests will do that for me.
Additional context
For the future, add something similar for: