Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEBUG_ONLY flag for more consistency in "seeing this is a bug" #71065

Merged
merged 2 commits into from
Jan 21, 2024

Conversation

NetSysFire
Copy link
Member

Summary

None

Purpose of change

We have a dozen or more ways of saying "seeing this is a bug" and I find that we duplicate this pointlessly, so this is an effort to have some consistency.

Describe the solution

  1. Adds the DEBUG_ONLY flag
  2. Applies this to fake_item and creates fake_crafting_item for deduplicating use.
  3. fake_item now also has TRADER_AVOID
  4. Removes most duplicated information
  5. Moves the fake butter churn to the proper file

Includes: Bonus typo and terminal punctuation (consistency!) fixes in flags.json

Describe alternatives you've considered

Testing

Loads and looks fine. Though I have not tested the recipes yet and I hope the tests will do that for me.

Additional context

For the future, add something similar for:

  • AI tag effects the player should not have
  • Maybe also for mutations?

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons labels Jan 19, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • This is not intended to be visible during normal gameplay. Please file a bug report unless you are seeing this in the debug menu.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jan 19, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 19, 2024
@Maleclypse Maleclypse merged commit 9917cc8 into CleverRaven:master Jan 21, 2024
20 of 24 checks passed
Procyonae pushed a commit to Procyonae/Cataclysm-DDA that referenced this pull request May 24, 2024
…rRaven#71065)

* DEBUG_ONLY flag

* apparently a fake item being wood triggers the density tests
Maleclypse pushed a commit that referenced this pull request May 26, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Merge pull request #70359 from mqrause/reload_inv_selector

Migrate reload ammo selection menu to inventory_selector

* DEBUG_ONLY flag for more consistency in "seeing this is a bug" (#71065)

* DEBUG_ONLY flag

* apparently a fake item being wood triggers the density tests

---------

Co-authored-by: mqrause <[email protected]>
Co-authored-by: NetSysFire <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.H Backported astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants