Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xedra Evolved] More Sylph traits #70999

Merged
merged 11 commits into from
Jan 17, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Jan 16, 2024

Summary

Mods "[Xedra Evolved] More Sylph traits"

Purpose of change

It's Sylph's turn.

Describe the solution

Adds the following traits:

PASSIVE TRAITS

  • Carried on the Breeze: Allows the sylph to direct their movement when falling, gliding forward instead of falling straight down. Upgraded from Slow Fall
  • Winds Guide Me: When outdoors, the sylph moves 10% faster. (Requires Pushing Wind) Upgrades to:
  • Outrunning the Gale: When outdoors, the sylph has 10% more speed and moves 10% faster. (Requires Stormwind stride)
  • Wind-Carried Weapons: The Sylph's ranged attacks go 10% farther (20% farther if they are post-threshold). (Requires Winds Guide Me)
  • Ice-Clear Thoughts: +2 Intelligence. (Requires Cloud Skin). Changes to:
  • Lightning Mind: +4 Intelligence.
  • Zephyr Chant: While outdoors, the sylph casts spells 20% faster (Requires Lightning Mind)

SPELL-GRANTING TRAITS

  • Stormwind Stride: Allows the sylph to charge forward, carried on the winds. (Requires Winds Guide Me)

ACTIVE TRAITS

  • Updraft Leap: Leap straight up and then hover and move on the winds for a moment before falling back to the earth. The sylph can choose to jump up two stories, four stories, or (if post-threshold) six stories (Requires (Cloud Skin or Storm Skin) and Carried on the Breeze)

POST-THRESHOLD TRAITS

  • Fist of Heaven's Fury: Call down a lightning bolt while outdoors, doing lightning damage and hurling targets away from the impact point. Also causes a crater where it hits (Requires Lightning Mind and Electrical Emissions) I wanted this to start a fire too like actual lightning can, but it looks like lightning fields override fires
  • Surmounting the Clouds: The Sylph can fly at will, though it requires a mana cost per turn. They must use Updraft Leap to rise but afterwards can walk wherever they want. (Requires Updraft Leap)
  • Whistling Zephyr Chant: While outdoors, the Sylph cast spells 20% faster and they no longer need to move their hands or arms to cast spells. (transformed from Zephyr Chant, requires Storm Skin)

Also updated the Sylph's fae ban preventing them from spending too long indoors so that it only triggers if they have Surmounting the Clouds.

Describe alternatives you've considered

Testing

Everything works

Additional context

Still have more ideas, stopping at 550 lines.

Also found a weird bug related to using u_is_outside in mutations, hence the extra lines.

@Standing-Storm Standing-Storm marked this pull request as draft January 16, 2024 17:34
@github-actions github-actions bot added Mods Issues related to mods or modding [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Mechanics: Enchantments / Spells Enchantments and spells EOC: Effects On Condition Anything concerning Effects On Condition Mods: Xedra Evolved Anything to do with Xedra Evolved labels Jan 16, 2024
@github-actions github-actions bot requested a review from Maleclypse January 16, 2024 17:43
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @GuardianDll

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 16, 2024
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 16, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 16, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review January 16, 2024 22:16
@Standing-Storm Standing-Storm marked this pull request as draft January 17, 2024 02:29
@Standing-Storm
Copy link
Contributor Author

Okay, fixed needing mutation switching. This needs to be merged after #71011 or mutating Winds Guide Me or Outrunning the Gale will crash the game.

@Standing-Storm Standing-Storm marked this pull request as ready for review January 17, 2024 03:12
@Maleclypse Maleclypse merged commit da483b6 into CleverRaven:master Jan 17, 2024
28 of 31 checks passed
@Standing-Storm Standing-Storm deleted the paraclesian-spells branch January 17, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants