-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Xedra Evolved] More Sylph traits #70999
Merged
Maleclypse
merged 11 commits into
CleverRaven:master
from
Standing-Storm:paraclesian-spells
Jan 17, 2024
Merged
[Xedra Evolved] More Sylph traits #70999
Maleclypse
merged 11 commits into
CleverRaven:master
from
Standing-Storm:paraclesian-spells
Jan 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Mods
Issues related to mods or modding
[JSON]
Changes (can be) made in JSON
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Mechanics: Enchantments / Spells
Enchantments and spells
EOC: Effects On Condition
Anything concerning Effects On Condition
Mods: Xedra Evolved
Anything to do with Xedra Evolved
labels
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-requesting reviews from non-collaborators: @GuardianDll
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
labels
Jan 16, 2024
github-actions
bot
added
BasicBuildPassed
This PR builds correctly, label assigned by github actions
and removed
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Jan 16, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jan 16, 2024
…m/Cataclysm-DDA into paraclesian-spells
Okay, fixed needing mutation switching. This needs to be merged after #71011 or mutating Winds Guide Me or Outrunning the Gale will crash the game. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
EOC: Effects On Condition
Anything concerning Effects On Condition
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mechanics: Enchantments / Spells
Enchantments and spells
Mods: Xedra Evolved
Anything to do with Xedra Evolved
Mods
Issues related to mods or modding
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[Xedra Evolved] More Sylph traits"
Purpose of change
It's Sylph's turn.
Describe the solution
Adds the following traits:
PASSIVE TRAITS
SPELL-GRANTING TRAITS
ACTIVE TRAITS
POST-THRESHOLD TRAITS
Also updated the Sylph's fae ban preventing them from spending too long indoors so that it only triggers if they have Surmounting the Clouds.
Describe alternatives you've considered
Testing
Everything works
Additional context
Still have more ideas, stopping at 550 lines.
Also found a weird bug related to using u_is_outside in mutations, hence the extra lines.