Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault when using vehicle tool to hacksaw #70945

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented Jan 14, 2024

Summary

None

Purpose of change

Fix #68541

Describe the solution

The hacksaw activity was not set up to use a vehicle tool and was segfaulting when trying to do so. Added logic to handle using a vehicle tool.

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added Vehicles Vehicles, parts, mechanics & interactions [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 14, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 15, 2024
@Maleclypse Maleclypse merged commit ea574d6 into CleverRaven:master Jan 16, 2024
20 of 26 checks passed
@Ramza13 Ramza13 deleted the fix-vehicle-hacksawing branch January 21, 2024 20:02
@Procyonae Procyonae added the 0.H Backport PR to backport to the 0.H stable release canddiate label May 20, 2024
Procyonae pushed a commit to Procyonae/Cataclysm-DDA that referenced this pull request May 20, 2024
* Fix

* fix

* Update activity_actor_definitions.h
kevingranade pushed a commit to Procyonae/Cataclysm-DDA that referenced this pull request May 26, 2024
* Fix

* fix

* Update activity_actor_definitions.h
kevingranade added a commit that referenced this pull request May 27, 2024
@Procyonae Procyonae added 0.H Backported and removed 0.H Backport PR to backport to the 0.H stable release canddiate labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.H Backported astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using angle grinder or reciprocating saw to cut bars from mounted workshop crashes game.
3 participants