Downward movement bug fix #70819
Merged
Downward movement bug fix #70819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Bugfix>
github-actions
bot
added
astyled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fixes improper behavior when moving down"
Purpose of change
Fixes #70809 and #70802
#70479 included a piece of logic to make it possible to traverse down Z levels midair without falling, but I set it up wrong so the check was always true. This fixes it.
Describe the solution
Delete the check for there not being a ledge.
Describe alternatives you've considered
Completely redoing up/down movement because it's very weird.
Testing
Made a guy, tried gliding, tried going down on solid ground and saw it wasn't possible
Additional context