-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profession/background condition #70818
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does this also work with hobbies? |
Nope, not yet. I'm thinking of implementing that one too though. Edit: decided to implement now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[C++]
Changes (can be) made in C++. Previously named `Code`
<Documentation>
Design documents, internal info, guides and help.
<Enhancement / Feature>
New features, or enhancements on existing
EOC: Effects On Condition
Anything concerning Effects On Condition
json-styled
JSON lint passed, label assigned by github actions
[Markdown]
Markdown issues and PRs
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features "add a profession condition for EOCs"
Purpose of change
It was weird to me that there was no profession/background condition. I've added this mainly for the npc dialogues, like a troubled character can ask to do a confession if you are a priest, or you can speak with the refugee center EMT about the hard days before cataclysm if you were an EMT. Or speak with someone about a hobby if you have a certain background. Just some roleplaying stuff.
But I think it would be otherwise useful as well. Maybe it can help unhardcode few profession related things, like churl or foodperson dialogue.
Describe the solution
Add a "u_profession" condition that reads the player's profession id and returns true if the player has that background or hobby(background). That's it.
Describe alternatives you've considered
don't do this ( please do this :( )
Testing
For testing purposes smokes at the refuge center will have surprise for career politicians




As you see this person has no extra dialogue because he isn't a career politician now let's try that with a politician:
Additional context
Patiently waiting for @nornagon 's #70808 so I can adjust the code accordingly.