Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profession/background condition #70818

Merged
merged 5 commits into from
Jan 14, 2024
Merged

Conversation

KeremBabaG
Copy link
Contributor

@KeremBabaG KeremBabaG commented Jan 10, 2024

Summary

Features "add a profession condition for EOCs"

Purpose of change

It was weird to me that there was no profession/background condition. I've added this mainly for the npc dialogues, like a troubled character can ask to do a confession if you are a priest, or you can speak with the refugee center EMT about the hard days before cataclysm if you were an EMT. Or speak with someone about a hobby if you have a certain background. Just some roleplaying stuff.

But I think it would be otherwise useful as well. Maybe it can help unhardcode few profession related things, like churl or foodperson dialogue.

Describe the solution

Add a "u_profession" condition that reads the player's profession id and returns true if the player has that background or hobby(background). That's it.

Describe alternatives you've considered

don't do this ( please do this :( )

Testing

For testing purposes smokes at the refuge center will have surprise for career politicians
Ekran görüntüsü 2024-01-10 082750
As you see this person has no extra dialogue because he isn't a career politician now let's try that with a politician:
Ekran görüntüsü 2024-01-10 083007
Ekran görüntüsü 2024-01-10 083016
Ekran görüntüsü 2024-01-10 083023

Additional context

Patiently waiting for @nornagon 's #70808 so I can adjust the code accordingly.

@KeremBabaG KeremBabaG marked this pull request as draft January 10, 2024 05:44
@github-actions github-actions bot added Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [C++] Changes (can be) made in C++. Previously named `Code` EOC: Effects On Condition Anything concerning Effects On Condition labels Jan 10, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jan 10, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added <Enhancement / Feature> New features, or enhancements on existing astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 10, 2024
@Standing-Storm
Copy link
Contributor

Does this also work with hobbies?

@KeremBabaG
Copy link
Contributor Author

KeremBabaG commented Jan 10, 2024

Does this also work with hobbies?

Nope, not yet. I'm thinking of implementing that one too though.

Edit: decided to implement now

@KeremBabaG KeremBabaG changed the title profession condition profession/background condition Jan 10, 2024
@github-actions github-actions bot removed the astyled astyled PR, label is assigned by github actions label Jan 10, 2024
@KeremBabaG
Copy link
Contributor Author

Without Driving License background:
resim_2024-01-10_203553229

With Driving License background:
Ekran görüntüsü 2024-01-10 202647

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 10, 2024
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [Markdown] Markdown issues and PRs labels Jan 10, 2024
@KeremBabaG KeremBabaG marked this pull request as ready for review January 10, 2024 18:37
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 10, 2024
@Maleclypse Maleclypse merged commit bfa956e into CleverRaven:master Jan 14, 2024
@KeremBabaG KeremBabaG deleted the u_profession branch January 14, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. <Enhancement / Feature> New features, or enhancements on existing EOC: Effects On Condition Anything concerning Effects On Condition json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants