jsonize toolweapon actions

[nornagon]

Summary

Infrastructure "Added transform_item and turn_cost EOC effects, and has_ammo condition"

Purpose of change

Expands the capabilities of item EOCs enough to JSONize all the
toolweapon effects (trimmer, carver, chainsaw, masonrysaw etc.).

Describe the solution

• Replaced the toolweapon use_actions and tick_actions by EOCs.
• Added new has_ammo conditional to allow the EOC to fail if the chainsaw is
  out of ammo. This calls ammo_sufficient under the hood.
• Added new transform_item effect which calls convert.
• Added new turn_cost effect to add a move cost to an activation EOC. Counts
  in turns instead of moves because this way I could reuse the duration_var
  infrastructure, so you can specify this in seconds in a string if you want.

The only thing I haven't ported over is the chainsaw idle / theme ambient sounds. I'll add an EOC effect to control ambient sounds once #70898 lands.

Describe alternatives you've considered

Maybe this is better off staying in C++? I feel like the JSON is more flexible
and moddable, and it seems weird to me for chainsaws to be "blessed" in this
way. But the new JSON is quite a bit more verbose than the old JSON. It would
be nice if there were a less-verbose way to say "invoke this EOC with these
variables".

Testing

• Activate a charged combat chainsaw, then checked:
  • Move cost was applied
  • Message was printed (NB this is a bugfix! In current experimental, no
    message is printed when you successfully start a chainsaw.)
  • The item was converted to it's _on variant
  • The running sounds messages are printed every now and then
• Manually deactivate a charged combat chainsaw (on)
  • The deactivate message is printed
  • The item is transformed to _off
• Activate a charged combat chainsaw while underwater
  • The failure message is printed
  • The item is not transformed
• Activate a combat chainsaw with no fuel
  • The failure message is printed
  • The item is not transformed
• Activate a charged combat chainsaw, then move underwater
  • The drown message is printed
  • The item is reverted to _off

Additional context

[GuardianDll]

Isn't there only a chance to start a saw when you activate it? Or it's only for generic chainsaw?

[nornagon]

Isn't there only a chance to start a saw when you activate it? Or it's only for generic chainsaw?

Yeah, that's only for the generic chainsaw, the combat saws are guaranteed-start. Though with this change it'd be possible to tweak that in JSON :)

[nornagon]

Also jsonized carver_off here. It had a "works underwater" flag set in the C++, but the JSON for that object has the "WATER_BREAK_ACTIVE" flag, which makes more sense.

[github-actions]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• With a roar, the polesaw screams to life!

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

[Maleclypse]

I'm going to let you handle the conflict on this one.

[GuardianDll]

May i ask to document new effects that was added in this PR? specifically turn_cost, has_ammo and transform_item in EFFECT_ON_CONDITION.md, and damage_level in NPCs.md (unless i miss some more changes)

[nornagon]

@GuardianDll will do in a followup now that this has been merged.