Adds a recipe for leather riding jackets, changes their name to 'motorcycle jacket'

[carlarctg]

Summary

Content "Adds a recipe for leather riding jackets, changes their name to 'motorcycle jacket'"

Purpose of change

There was some confusion with armored leather jackets, leather riding jackets, and normal leather jackets. Or at least on my part. I also found it unreasonable that you could craft LJs, make ALJs, but not make LRJs, meaning you can't actually make armored leather jackets from scratch.

Describe the solution

Renamed the leather riding jackets to motorcycle jackets.
Improved the description of normal leather jackets.
Added a recipe for motorcycle jackets.

Describe alternatives you've considered

I considered doing the alternate thing, and instead renaming the OG leather jacket to 'light leather jacket'. Up to the devs if that's a better solution.

Testing

Spawned myself in, ensured the recipes were there, craftable, and goode.

Additional context

@fairyarmadillo I would appreciate your input on this PR's contents since you said exactly why the last one was bad. Hopefully this one is more reasonable.

Also, unrelated, but there's no way to make patchwork/quilts ingame ATM, making wool gambesons uncraftable! Well, without looting houses, but that's silly. I have even less of an idea how to handle a quilt recipe, so if you could fix that or give me pointers as to how I'd greatly appreciate it. (Are you on the discord?)

[worm-girl]

Don't change the name IMO. A riding jacket is what it is called IRL. Anyone who doesn't know the difference can simply look at it and see that it's described as thick, or they can see the material thickness on it. Nobody calls them "thick leather jackets".

Otherwise yeah it was weird that you couldn't craft them. And no I'm generally not on the discord.

[carlarctg]

Sorry to disagree, but I'd really rather have a way to separate them in name. Also, both jackets are described as thick.

[worm-girl]

Sorry to disagree, but I'd really rather have a way to separate them in name. Also, both jackets are described as thick.

Then the regular leather jacket definitely needs its description changed, because it specifically isn't thick.

'thick leather jacket' is a bad name. It's less descriptive than riding jacket and is not what the item is called. Thick relative to what? That would be like calling a sledgehammer a thick hammer, or a food processor an electric food chopper bowl. You're also making it sound like there are thin versions of the police and biker gang jackets when there aren't and wouldn't be.

'leather riding jacket' tells you exactly what the item is. It's on you if you don't know the term, that's why items have descriptions and stats. There are tons of items named this way, like turnout coat, activity suit, combat boots, etc. - it's up to you to look at it closer if you need further information. This is just how we name items in this game.

If it's really that important, consider calling it a motorcycle jacket/police motorcycle jacket instead of a leather riding jacket. The biker gang jacket could stay as it is. At a stretch I might suggest heavy, but heavy leather police jacket is way too long of a name.

Fabric IRL is not referred to by its thickness, which can vary when it's wet, compressed, worn out, etc., but by its weight. We only use thickness in our code because that's just how the material system works.

[KeremBabaG]

I agree with the other guy, when you describe a riding jacket made of thick leather with the purpose of biking you name it riding jacket not "thick"

Moreover in no other piece of clothing we do this, at most it's "heavy" and not thick

[carlarctg]

Moreover in no other piece of clothing we do this, at most it's "heavy" and not thick

'It's just how we've always done it!' is not a proper argument. That said I am going to be taking fairy's other suggestion.

[worm-girl]

You probably don't need to use the word "thick" twice in the description, nor do you need to mention that it can support extra "padding" - that's meaningless information 90% of the time, and padding generally refers to soft things, not metal.

I think you're getting really wrapped around the axle about thickness and one possible use case for the item, which is irrelevant to most characters, especially if they lack the skills to know the one recipe you're referring to. Just describe the thing as it is.

[carlarctg]

What the fuck failed. These tests are so annoying