Add WIP Limb Stuff mod and move mainline limby stuff over #70721
Conversation
github-actions
bot
added
[JSON]
github-actions
bot
added
the
astyled
|
#70443 adds two new limbs for bird wings, replacing the mutant's arms and hands. The PR will still function without those parts being limbified, but given that it's about ready to merge, would it be possible to wait for that to happen, then move the limbs over to the mod? It would make my life easier. |
|
Whoops, I mean #70479 |
|
The law of the land is "first merged wins" - if yours makes it in first the conflict resolution is on me and vice versa. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Auto-requesting reviews from non-collaborators: @Standing-Storm @Light-Wave
github-actions
bot
added
json-styled
|
So many conflicts |
Well if only y'all didn't merge limby stuff... Migrated bird wings over and rebased, should be ready now. |
github-actions
bot
removed
the
BasicBuildPassed
|
Proceeded to fail tests I didn’t even know existed ;) |
github-actions
bot
added
the
Mods: Magiclysm
There was a problem hiding this comment.
Auto-requesting reviews from non-collaborators: @GuardianDll
|
I see you ran into the same confusion I did when I was trying to fix the ravenfolk errors. I was gonna be helpful and instead I just complained in discord. |
github-actions
bot
added
Code: Tooling
Actual fix fix maybe? Fix fix fix + test armor Imma have to squash this mess to oblivion I swear to Glob This is getting awkward
github-actions
bot
removed
the
BasicBuildPassed
|
I am not 100% sure what the design intent for ravenfolk is. They were using Bird's bird_wings mutation so I gave them parity with that, but it may be the original contributor's intent that they have wings separate from their arms. |
github-actions
bot
added
the
BasicBuildPassed
|
I don’t see recipes for making prosthetic legs and arms after the system was added to a separate mod. for now just look in spawn places? |
Slight migration problem, I'll have a fix up soonish. |
BrettDong
added
the
0.H Backport
Procyonae
removed
the
0.H Backport
…n#70721) * First migration * Second * Migration From Hell's Heart I lint at thee We'll get there * Ravenfolk fix Actual fix fix maybe? Fix fix fix + test armor Imma have to squash this mess to oblivion I swear to Glob This is getting awkward * Done playin
…n#70721) * First migration * Second * Migration From Hell's Heart I lint at thee We'll get there * Ravenfolk fix Actual fix fix maybe? Fix fix fix + test armor Imma have to squash this mess to oblivion I swear to Glob This is getting awkward * Done playin
…n#70721) * First migration * Second * Migration From Hell's Heart I lint at thee We'll get there * Ravenfolk fix Actual fix fix maybe? Fix fix fix + test armor Imma have to squash this mess to oblivion I swear to Glob This is getting awkward * Done playin
…n#70721) * First migration * Second * Migration From Hell's Heart I lint at thee We'll get there * Ravenfolk fix Actual fix fix maybe? Fix fix fix + test armor Imma have to squash this mess to oblivion I swear to Glob This is getting awkward * Done playin
…n#70721) * First migration * Second * Migration From Hell's Heart I lint at thee We'll get there * Ravenfolk fix Actual fix fix maybe? Fix fix fix + test armor Imma have to squash this mess to oblivion I swear to Glob This is getting awkward * Done playin
…n#70721) * First migration * Second * Migration From Hell's Heart I lint at thee We'll get there * Ravenfolk fix Actual fix fix maybe? Fix fix fix + test armor Imma have to squash this mess to oblivion I swear to Glob This is getting awkward * Done playin
* Add WIP Limb Stuff mod and move mainline limby stuff over (#70721) * First migration * Second * Migration From Hell's Heart I lint at thee We'll get there * Ravenfolk fix Actual fix fix maybe? Fix fix fix + test armor Imma have to squash this mess to oblivion I swear to Glob This is getting awkward * Done playin * Ravenfolk test failures * Try to fix WINGS_BIRD categories --------- Co-authored-by: Venera3 <[email protected]>
Summary
Content "Add WIP Limb Stuff Mod"
Purpose of change
Begin #70703 with moving in-progress content to a mod that communicates its WIP-ness.
Describe the solution
Added a WIP Limb Stuff Mod, made myself its code owner
Moved limby JSON over to the mod
Describe alternatives you've considered
Obsoleting all of it to keep in-progress amputee characters safe, but that just shifts breakage down the line to when this stuff will have been reworked and begins its migration back to mainline.Went with the safe way.
Testing
Started a normal save without the mod - no errors
Started a canned amputee save - some missing EOC errors, on load (and waiting one tick) get the informative popup and my limbs back
Started a modded save - no errors
Additional context