Add bronze variants to many recipes. #70712
Conversation
|
You are creating a pull request with the master branch as the head branch. This is likely a mistake unless you really know what you are doing. You may read https://docs.github.com/en/get-started/quickstart/contributing-to-projects#creating-a-branch-to-work-on for a typical workflow of contributing to a project on GitHub. |
github-actions
bot
added
new contributor
[JSON]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
JSON & C++ formatters
data/json/recipes/armor/arms.json|1738|
data/json/recipes/armor/arms.json|1955|
data/json/recipes/armor/arms.json|2243|
data/json/recipes/armor/arms.json|2260|
data/json/recipes/armor/feet.json|1935|
data/json/recipes/armor/feet.json|1957|
data/json/recipes/armor/hands.json|1450|
data/json/recipes/armor/hands.json|1472|
data/json/recipes/armor/hands.json|1689|
data/json/recipes/armor/hands.json|1711|
data/json/recipes/armor/head.json|2938|
data/json/recipes/armor/head.json|2955|
data/json/recipes/armor/head.json|3090|
data/json/recipes/armor/head.json|3107|
data/json/recipes/armor/head.json|3242|
data/json/recipes/armor/head.json|3259|
data/json/recipes/armor/legs.json|1778|
data/json/recipes/armor/legs.json|1795|
data/json/recipes/armor/legs.json|1937|
data/json/recipes/armor/legs.json|1954|
data/json/recipes/armor/legs.json|2096|
data/json/recipes/armor/legs.json|2113|
data/json/recipes/armor/storage.json|1062|
data/json/recipes/armor/suit.json|2593|
data/json/recipes/armor/suit.json|2602|
data/json/recipes/armor/suit.json|2964|
data/json/recipes/armor/suit.json|2973|
data/json/recipes/armor/suit.json|3347|
data/json/recipes/armor/suit.json|3356|
data/json/recipes/other/parts_construction.json|24|
data/json/recipes/recipe_ammo.json|265|
data/json/recipes/recipe_ammo.json|447|
data/json/recipes/recipe_others.json|2935|
data/json/recipes/tools/tools_hand.json|1480|
data/json/recipes/tools/tools_hand.json|1590|
data/json/recipes/tools/tools_primitive.json|80|
data/json/recipes/tools/tools_primitive.json|104|
data/json/recipes/weapon/cutting.json|100|
data/json/recipes/weapon/cutting.json|711|
data/json/recipes/weapon/cutting.json|816|
data/json/recipes/weapon/cutting.json|917|
data/json/recipes/weapon/cutting.json|1268|
data/json/recipes/weapon/cutting.json|1369|
data/json/recipes/weapon/cutting.json|1470|
data/json/recipes/weapon/cutting.json|1571|
data/json/recipes/weapon/cutting.json|1672|
data/json/recipes/weapon/cutting.json|1773|
data/json/recipes/weapon/cutting.json|1874|
data/json/recipes/weapon/cutting.json|1975|
data/json/recipes/weapon/cutting.json|2076|
data/json/recipes/weapon/cutting.json|2177|
data/json/recipes/weapon/cutting.json|2501|
data/json/recipes/weapon/cutting.json|2602|
data/json/recipes/weapon/explosive.json|232|
data/json/recipes/weapon/piercing.json|1046|
data/json/recipes/weapon/piercing.json|1409|
data/json/recipes/weapon/ranged.json|1310|
data/json/requirements/toolsets.json|99|
data/json/requirements/toolsets.json|106|
Overall I was hoping we'd wait with bronze tools until we can implement tools wearing out as they're used... But I can't stop you if it does make sense, and I'd like Drew to confirm whether it does. |
Not yet, that might need a bit more research (and I wasn't sure how open to such a change CDDA was)
Will check - I left bronze nails out of vehicles (i'm unsure if that would structurally make sense, I believe bronze is stronger [or can be] than iron, but less than steel) |
Bronze files are viable, subject to greater wear than iron/steel, and not really suitable for working on harder metals like carbon steel but will probably work well enough. IIRC our in-game bronze isn't a specific alloy so there is some variance between a copper/tin alloy and one with aluminum, but without adding a dozen alloys I'd let this proceed. |
A nice resource is MakeItFrom.com, you need to know a bit about what you're looking at but it does a good job of showing side-by-side comparisons. In general, brone/copper alloy is approximate to steel but heavier and more likely to deform than fracture (bend vs. break). Bronze nails are fine for things like a wooden wagon or cart. |
|
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
github-actions
bot
added
astyled
* Initial Commit * Why so many :c * Regex to the rescue * Change any_nail to nails * Revert "Change any_nail to nails" This reverts commit 2fa5487. * Revert "Regex to the rescue" This reverts commit ee613a9. * Regex to the rescue except correct this time * any_nail -> nails again * Catch the stragglers * Requirements * any_hotcut * any_metalworking_tongs * any_metalworking_file * Better requirement names * Lint * Minor errors --------- Co-authored-by: Maleclypse <[email protected]>
Summary
Content "Add bronze variants to ingredients for many recipes"
Purpose of change
I enjoy mods such as Innawood, but the base game lacks some of the basic bronze items/construction paths. This patch is the first (if it's accepted and worth doing!) to try and introduce parity for bronze age construction and crafting, alongside the (default) "steel age".
Describe the solution
For each key item, e.g. "nail", i've introduced a bronze variant (recipe for those will follow in future), as an alternative ingredient.
Describe alternatives you've considered
None
Testing
I've tested it in the base game. I need to do more testing with some of the bundled mods to see if it causes 'downstream' problems.
Additional context