Don't calculate safe speed for stationary vehicles for SFX #70676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Performance "Optimize stationary vehicle performance when they contain a lot of items."
Purpose of change
Turning the engine on generates SFX, and that requires getting the safe speed of a vehicle, which requires getting the mass of all items on the vehicle. This isn't needed if the vehicle is stationary.
Fix #68982
Describe the solution
Delay computing the safe speed until it is needed.
Describe alternatives you've considered
This could be fixed for moving vehicles by caching the item mass, but that would require a lot of investigation into where that cache would need to be invalidated. It's probably fine for moving vehicles to slow the game down, since that is done interactively most of the time and won't be noticed.
Testing
Additional context
Before:

After:
