Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pocket mods now support inheritance #70625

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

Close #69936

Describe the solution

Apply solution, provided by EIIKaO
Clean up excessive json in conversions.json, since now it is inherited properly

Testing

Spawned AR-15, attached every receiver it may have, shoot once
Cleaned up json, did the same again, result is identical

Additional context

Thank you EIIKaO for help!

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 3, 2024
@Maleclypse Maleclypse merged commit 1ec6b8c into CleverRaven:master Jan 4, 2024
24 of 28 checks passed
@GuardianDll GuardianDll deleted the pocket_mods branch January 4, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

copy-from is not compatible with pocket_mods
2 participants