Add int_id_set and swap global mon_flag_str_ids to mon_flag_ids.
#70588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type.h`. Initialize them on game load.
github-actions
bot
added
NPC / Factions
github-actions
bot
added
the
json-styled
github-actions
bot
added
the
BasicBuildPassed
akrieger
reviewed
Jan 2, 2024
gkarfakis19
added a commit
to gkarfakis19/Cataclysm-DDA
that referenced
this pull request
Jan 2, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Performance "Optimize monster flag checking."
Purpose of change
See issue #70399
Describe the solution
Add a simple set container optimized for
int_ids produced from ageneric_factory. Replace all global string_id monster flags with the int_id version. This transformation is safe, as any use that requires the ID to be stable would result in a type error (or would already be bugged, and this would not change that).Describe alternatives you've considered
Testing
Unit tests pass.
Additional context
These were taken with #70274 and #70546 merged, as they add a lot of noise. Two samples before and after, since the profiles are now much more stable.
Before:
After:
