Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bridgehead_ramp vehicle nests #70568

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

Procyonae
Copy link
Contributor

Summary

None

Purpose of change

I forgot to remove the vehicle spawns from the z1 bridgehead_ramp during #70098 at CoroNaut's request where you're very likely to crash in to them if not peeking up the z level

Describe the solution

Straight up yeets them

Describe alternatives you've considered

Also removing the bridgehead_ground ones

Testing

Additional context

Thanks to TheMurderUnicorn for pointing this out ^^

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Vehicles Vehicles, parts, mechanics & interactions json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 31, 2023
@Maleclypse
Copy link
Member

I feel like these are less of a gotcha and more of a "you should drive carefully around corners in the apocalypse because there are wrecked cars everywhere especially around blind corners and up ramps." This sounds like "I keep wrecking on the one out of twenty bridges that have wrecks on them because they are such a low occurrence and I drive 80 miles an hour around blind corners because no one punishes me". Why wouldn't a better PR increase the number of wrecks at these blindspots?

@Maleclypse
Copy link
Member

I can probably be convinced this is a good idea to merge, but I'm just not sure.

@Procyonae
Copy link
Contributor Author

I mean the only way to tell there's a wreck there is to use "experimental" z vision and peek up. I'm leaving the ones at ground level bc I think we can expect the average player to be using the depth vision stuff but having to peek up is a bit eh and irl it wouldn't be a blindspot just a mild incline, the only reason it's a z level change is so boats fit under bridges

@Procyonae
Copy link
Contributor Author

Procyonae commented Jan 1, 2024

This does also only give ~12 tiles of leeway, if you're going 80mph and not playing upmost attention you'll still crash with the new closest spawn (I could've gone further and had no vehicles/half a map of vehicles on the bridge_road if adjacent to bridgehead_ramp too)

@Maleclypse Maleclypse merged commit fe2a129 into CleverRaven:master Jan 1, 2024
19 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants