Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for auto consume issue #70516

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented Dec 29, 2023

Summary

None

Purpose of change

Fix #69173

Describe the solution

Auto consume time was being calculated incorrectly and was returning a negative value in some cases which screwed over a bunch of math and was causing this freeze. The existing save is after the bug and will still be stuck but the issue won't happen again.

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 29, 2023
@Maleclypse Maleclypse merged commit ff71dff into CleverRaven:master Dec 30, 2023
27 checks passed
@Ramza13 Ramza13 deleted the fix-auto-consume-bugs branch December 30, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessing memory cards take more than 20 hours, characters die and unable to escape task.
2 participants