[Bombastic Perks] Add some new perks #70481
Conversation
github-actions
bot
added
[JSON]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Auto-requesting reviews from non-collaborators: @bombasticSlacks
github-actions
bot
added
astyled
github-actions
bot
added
BasicBuildPassed
github-actions
bot
added
the
BasicBuildPassed
|
Hey sorry I didn't get to review this before merging, I'm going to make a few notes as comments, no pressure to fix them I'll compile and do it sometime soon if you don't 😄 Thanks for contributing perks! |
| "and": [ | ||
| { "u_has_trait": "perk_quick_recovery" }, | ||
| { "x_in_y_chance": { "x": 3, "y": 4 } }, | ||
| { "or": [ { "compare_string": [ "downed", { "context_val": "effect" } ] } ] } |
There was a problem hiding this comment.
I think this "or" isn't necessary.
There was a problem hiding this comment.
Originally it also did "or dazed" but I decided that was better than "kinda okay" so I removed it but not the or. I'll take that out.
| "rating": "good", | ||
| "int_dur_factor": "1 s", | ||
| "max_duration": "2 s", | ||
| "show_in_info": false |
There was a problem hiding this comment.
Probably worth showing when active
| }, | ||
| { "set_string_var": "perk_vengeful", "target_var": { "context_val": "trait_id" } }, | ||
| { | ||
| "set_string_var": "Requires handguns 2", |
There was a problem hiding this comment.
This is a typo I think
There was a problem hiding this comment.
You're right--I removed it from the actual requirements but not from the listed requirements
Summary
Mods "[Bombastic Perks] Add some new perks"
Purpose of change
Had an idea for a few new perks.
Describe the solution
Add three perks:
Describe alternatives you've considered
Testing
Everything is selectable and works.
Additional context