Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOM] Wakeful Rest Removes Sleep Deprivation and Fatigue #70433

Merged
merged 3 commits into from
Dec 26, 2023

Conversation

b3brodie
Copy link
Contributor

Summary

Mods "Make Wakeful Rest check sleep deprivation when starting"

Purpose of change

Wakeful rest removes both sleep deprivation and fatigue when meditating. However, it only checks fatigue when triggering / continuing the meditation, which means that if the user has sleep deprivation but no fatigue they are unable to use the ability to remove it.

Describe the solution

Add sleep_deprivation to value that is compared against. Therefore, if either sleep deprivation or fatigue is above zero the user can meditate to remove it. Negative values aren't an issue because the sub EOC's only remove fatigue / sleep deprivation if they are above 0.

Describe alternatives you've considered

N/A

Testing

  1. Used character with large amounts of sleep deprivation and no fatigue
  2. Used wakeful rest
  3. Successfully meditated and removed sleep deprivation

Additional context

N/A

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter labels Dec 25, 2023
@b3brodie b3brodie marked this pull request as ready for review December 25, 2023 07:05
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @Standing-Storm

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Dec 25, 2023
@b3brodie b3brodie marked this pull request as draft December 25, 2023 08:05
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 25, 2023
@b3brodie b3brodie marked this pull request as ready for review December 25, 2023 08:08
@github-actions github-actions bot removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 25, 2023
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 25, 2023
@Maleclypse Maleclypse merged commit f94a31e into CleverRaven:master Dec 26, 2023
21 of 23 checks passed
@b3brodie b3brodie deleted the mom_rest branch December 26, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants