Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My job is beach. #70173

Closed
wants to merge 11 commits into from
Closed

My job is beach. #70173

wants to merge 11 commits into from

Conversation

I-am-Erk
Copy link
Member

@I-am-Erk I-am-Erk commented Dec 12, 2023

Summary

None

Purpose of change

Now that we have beaches, we need stuff for them.

Describe the solution

Adds some minimal terrain and furniture for beach decoration:

  • f_beach_log: an old log on the beach.

  • f_broken_boat: a washed up chunk of an abandoned boat

  • f_beach_seaweed: seaweed piled at the high waterline

  • t_coast_rock: a rocky coastline to replace the sand

  • t_coast_rock_shole: the same, but on the edge of the water, to connect to the surf and create a graphically interesting edge

  • t_coast_rock_submerged: the same, but underwater in the shallows.

  • t_tidepool: a tidepool for putting in coastal rock

Adds the "beach_formations" connection group so that coast rock can connect to itself and its other versions, and sand can connect to it (but it doesn't connect to sand).

Enables all these in game by decorating beaches with specialized mapgen that utilizes neighbour recognition to get an idea of the directionality of the coastline and put the appropriately shaped coastal decor in place. [ in progress ]

image
f_broken_boat

image
f_beach_log

image
One view of a quick rendition of t_surf

Working on the tiles.

Describe alternatives you've considered

Things I'd like to add but likely won't have time:

  • a map special to make a few tiles of rocky coast that then fade into sand using map extras
  • a map special or extra that adds long dry beach grass and a little path leading to the water
  • docks and things

Testing

not tested yet

Additional context

A lot of people think this is a lifeguard update, but it's not, it's just beach.

We're just going with natural furniture for now.
I drew this one first and forgot to add the entry.
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. labels Dec 12, 2023
@I-am-Erk I-am-Erk marked this pull request as draft December 12, 2023 22:57
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 12, 2023
@MNG-cataclysm
Copy link
Contributor

A Cataclysm:DDA beach episode is coming soon, I suppose.

@ashGlaw
Copy link
Contributor

ashGlaw commented Dec 20, 2023

I see what you did there, Ken. 😉
Great work!

now that I have a better idea what I'm doing... do less of it.
@github-actions github-actions bot added the Map / Mapgen Overmap, Mapgen, Map extras, Map display label Dec 28, 2023
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Dec 28, 2023
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Jan 28, 2024
@Maleclypse Maleclypse added (P5 - Long-term) Long-term WIP, may stay on the list for a while. and removed stale Closed for lack of activity, but still valid. labels Feb 20, 2024
@Night-Pryanik
Copy link
Contributor

Closing as stale. If you wish to continue working on this, ping me to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display (P5 - Long-term) Long-term WIP, may stay on the list for a while.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants