Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing gun- or toolmods with pocket_mods updates the pockets #70044

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

mqrause
Copy link
Contributor

@mqrause mqrause commented Dec 7, 2023

Summary

None

Purpose of change

Removing a mod with pocket_mods didn't update the pockets, that only happened when inserting mods or loading a save.

Describe the solution

For a lack of determining what kind of pocket an item was removed from, update pockets when removing any item from any pocket.

Describe alternatives you've considered

Testing

Extended the test to also cover removing the mod again and it passes locally.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` Items: Containers Things that hold other things json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Dec 7, 2023
@Maleclypse Maleclypse merged commit 3438b6a into CleverRaven:master Dec 9, 2023
24 of 28 checks passed
@mqrause mqrause deleted the remove_pocket_mods_fix branch December 10, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants