Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit rabbi description + specify holy symbol variant #69775

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Nov 26, 2023

Summary

Content "Edit rabbi description + specify holy symbol variant"

Purpose of change

I've done enough Mind over Matter PRs, time for another Judaism one.

I went to pick rabbi as a profession and noticed that I started with an Orthodox Church cross holy symbol because no variant was specified. Also, the description always bugged me a little bit.

Describe the solution

Specify that rabbis start with a Star of David necklace. Change the description to:

You were davening Shacharit in shul when the Cataclysm struck. You had always taught that God will restore life to the dead after Moshiach has come, but not like this!

I can dial it back a bit if that's too much.

Describe alternatives you've considered

Testing

Changes reflected in game.

Additional context

I thought about putting "The Holy One, Blessed be He" instead of G-d but I had to draw the line somewhere.

Magiclysm tag because I edited the Magiclysm rabbi too

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Mods: Magiclysm Anything to do with the Magiclysm mod labels Nov 26, 2023
@github-actions github-actions bot requested a review from KorGgenT November 26, 2023 19:05
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @GuardianDll

Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • You were davening Shacharit in shul when the Cataclysm struck. You had always taught that God will restore life to the dead after Moshiach has come, but not like this!

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 26, 2023
Copy link
Contributor

@MNG-cataclysm MNG-cataclysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Maleclypse Maleclypse merged commit 326d760 into CleverRaven:master Nov 27, 2023
27 of 28 checks passed
@Standing-Storm Standing-Storm deleted the rabbi-change branch November 27, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants