Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Various maintenance tasks #69753

Merged
merged 15 commits into from
Nov 28, 2023

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Nov 26, 2023

Summary

Mods "[MoM] Various maintenance tasks"

Purpose of change

Some things need to be fixed

Describe the solution

Standardizes formatting of powers.
Standardizes removal of toggled powers into discrete EoCs that can be called elsewhere.
As part of above, adds various hidden effects for tracking non-effect-based powers (like Chameleoflage or Banked Flames)
Rename Drain to "Nether-Attuned," remove all innate negative effects, and rework messages around it, to prepare for changes down the line (see comments on #69428 )
Add a couple possible positive effects from Nether-Attuned (Health increase, surge of power)
Link remaining scaling effects into Jmath instead of using individual formulae.
Fixes repeated messages when stopping concentration on toggled powers.
Adds missed powers to End Concentration
Remove Stamina debuff from maintained powers (losing concentration discourages over-maintenance much better)
Converts powers to ternary so channeling time is 1/10 of a second and cost is 0 when turning off concentration

Describe alternatives you've considered

Testing

It works.

Should be enough changes for one PR. I'll have another one converting more powers to maintenance soon enough.

Additional context

@Standing-Storm Standing-Storm marked this pull request as draft November 26, 2023 01:10
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter astyled astyled PR, label is assigned by github actions labels Nov 26, 2023
Standing-Storm and others added 3 commits November 25, 2023 19:14
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 26, 2023
@github-actions github-actions bot added Mechanics: Enchantments / Spells Enchantments and spells and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 26, 2023
@Standing-Storm Standing-Storm marked this pull request as ready for review November 27, 2023 19:49
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 27, 2023
@Maleclypse Maleclypse merged commit 1beba4c into CleverRaven:master Nov 28, 2023
25 checks passed
@Standing-Storm Standing-Storm deleted the mom-maintenance branch November 28, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Mind Over Matter Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants