Change NPC faction from debug menu #69693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is built on top of #69690 |
github-actions
bot
added
[C++]
sparr
force-pushed
the
debug_npc_faction
branch
from
3863a33 to
a5d8bc6
Compare
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "Change NPC faction from debug menu"
Purpose of change
Moving NPCs between factions helps with testing many parts of NPC, faction, and mission code.
Describe the solution
Add option to debug menu when editing an NPC to select a new faction for them.
Describe alternatives you've considered
Testing
Changed some NPC factions, saw different behavior, then changed them back.
Additional context
I considered making select_faction more complex so that it could have a different message for different use cases, or automatically select a particular option like the current npc faction, but those seemed overkill for this initial implementation.